fix: prevent nil deref when reading in-memory tables#2316
Open
ErfanMomeniii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2105.
Hi, when Badger is running in in-memory mode (Options.InMemory = true), SSTables exist entirely in memory and don't have an underlying file. There were two error paths in (*Table).block that accessed the table's filename directly to produce a more descriptive error. Since in-memory tables don't have a file handle, those paths could dereference a nil pointer and panic.
This shows up whenever a block read fails on an in-memory table. A few real situations that trigger it:
The fix keeps things minimal.
Filename()now returns a stable, convention-matching name derived from the table ID when there's no file handle, and the two direct filename lookups inblock()go throughFilename()as well. On-disk tables are completely unaffected.Added two tests:
TestInMemoryTableBlockErrorNoPanic-- corrupts a compressed in-memory table and assertsblock()returns an error instead of panicking. Reproduces the exact panic from the issue onmainbefore the fix.TestInMemoryTableFilename-- verifies the synthesized name returned for an in-memory table.Checklist